-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added captcha requirement #605
Conversation
Reviewer's Guide by SourceryThis pull request implements a CAPTCHA requirement using Cloudflare's Turnstile service. It adds a new constraint for CAPTCHA verification, modifies existing validators to include the request object, and updates various files to support this new feature. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @alimaktabi - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding error handling and logging for Cloudflare API calls to improve debugging and resilience.
- The commented out migration command in start_dev.sh could cause issues. Either remove the comment or add a note explaining why it's commented out.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
…tapApp/unitap-backend into feature/requirements/captcha
@PooyaFekri |
Co-authored-by: pooya <[email protected]>
Co-authored-by: pooya <[email protected]>
Summary by Sourcery
Add CAPTCHA verification using Cloudflare's service to enhance security in token distribution and raffle enrollment processes. Update validators to handle request context for CAPTCHA checks and introduce a utility class for Cloudflare API interactions. Modify the start_dev.sh script to disable automatic migrations and update constraint options in the database schema.
New Features:
Enhancements:
Build:
Deployment:
Chores: