Skip to content

Commit

Permalink
fix: eric comments
Browse files Browse the repository at this point in the history
  • Loading branch information
marktoda committed Nov 15, 2023
1 parent a364561 commit 42b35c4
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
12 changes: 11 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,16 @@ Each command is a `bytes1` containing the following 8 bits:
├──────┼───────────────────────────────┤
│ 0x1d │ SWEEP_ERC1155 │
├──────┼───────────────────────────────┤
│ 0x1e │ ELEMENT_MARKET │
├──────┼───────────────────────────────┤
│ 0x1f │ ------- │
├──────┼───────────────────────────────┤
│ 0x20 │ SEAPORT_V1_4 │
├──────┼───────────────────────────────┤
│ 0x21 │ EXECUTE_SUB_PLAN │
├──────┼───────────────────────────────┤
│ 0x22 │ APPROVE_ERC20 │
├──────┼───────────────────────────────┤
│ 0x1e-│ ------- │
│ 0x3f │ │
└──────┴───────────────────────────────┘
Expand Down Expand Up @@ -220,7 +230,7 @@ yarn test:gas

### To Deploy

Fill out parameters in `script/deployParameters/Deploy<network>.s.sol`
Fill out parameters in `script/deployParameters/Deploy<network>.s.sol` \

```console
forge script --broadcast \
Expand Down
2 changes: 1 addition & 1 deletion contracts/base/Dispatcher.sol
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ abstract contract Dispatcher is NFTImmutables, Payments, V2SwapRouter, V3SwapRou
}
Payments.approveERC20(token, spender);
} else {
// placeholder area for commands 0x22-0x3f
// placeholder area for commands 0x23-0x3f
revert InvalidCommandType(command);
}
}
Expand Down

0 comments on commit 42b35c4

Please sign in to comment.