feat(sor): support routing on unichain mainnet #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@uniswap/[email protected], npm/@uniswap/[email protected], npm/@uniswap/[email protected], npm/@uniswap/[email protected], npm/@uniswap/[email protected], npm/@uniswap/[email protected] |
xrsv
commented
Nov 21, 2024
cgkol
reviewed
Nov 25, 2024
| @@ -663,6 +663,12 @@ export class OnChainQuoteProvider implements IOnChainQuoteProvider { | |||
| _providerConfig?.blockNumber ?? originalBlockNumber + baseBlockOffset, | |||
| }; | |||
|
|
|||
| log.info(`routes length: ${routes.length}`); | |||
There was a problem hiding this comment.
are we sure we want to add these and the ones underneath?
There was a problem hiding this comment.
good catch - will remove - this was for local debugging logs
Graphite Automations"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (11/25/24)3 reviewers were added and 1 assignee was added to this PR based on 's automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Support routing in SOR for Unichain Mainnet.
Also Renames
ASTROCHAIN_SEPOLIAtoUNICHAIN_SEPOLIAOther information:
Pending
JSON_RPC_PROVIDER_UNICHAIN_SEPOLIAandJSON_RPC_PROVIDER_UNICHAINsecrets in SOR