feat(v4-sdk): add permit2 forwarder support and other permit funcs #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion-createCallParameters
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (09/23/24)1 assignee was added and 1 reviewer was added to this PR based on 's automation. |
zhongeric
changed the title
zhongeric
commented
Sep 23, 2024
Comment on lines
+248
to
+256
| if (options.batchPermit) { | ||
| calldataList.push( | ||
| V4PositionManager.encodePermitBatch( | ||
| options.batchPermit.owner, | ||
| options.batchPermit.permitBatch, | ||
| options.batchPermit.signature | ||
| ) | ||
| ) | ||
| } |
There was a problem hiding this comment.
I feel like we don't need to support permit2 permit for either token0 OR token1. We can just do a batchPermit of 1 element in that case, simplifying the options interface
There was a problem hiding this comment.
i wonder how much more gas it is. But yeah we can always do this as a follow-up? Maybe worth opening an issue or something just in case its way more gas
There was a problem hiding this comment.
Yep just made an issue #107
hensha256
reviewed
Sep 24, 2024
hensha256
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Scope
Please title your PR according to the following types and scopes following conventional commits:
fix(SDK name):will trigger a patch versionchore(<type>):will not trigger any release and should be used for internal repo changes<type>(public):will trigger a patch version for non-code changes (e.g. README changes)feat(SDK name):will trigger a minor versionfeat(breaking):will trigger a major version for a breaking changeDescription
Relies on #102 , adds:
How Has This Been Tested?
[e.g. Manually, E2E tests, unit tests, Storybook]
Are there any breaking changes?
[e.g. Type definitions, API definitions]
If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title
feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.(Optional) Feedback Focus
[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]
(Optional) Follow Ups
[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]