Add mintBulkCross to NFT and RFT collections #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairax
force-pushed
the
feature/add_mint_bulk_cross
branch
4 times, most recently
from
d49c1ec to
33895cb
Compare
CertainLach
requested changes
Sep 13, 2023
pallets/common/src/eth.rs
Outdated
|
|
||
| /// Token minting parameters | ||
| #[derive(AbiCoder, Default, Debug)] | ||
| pub struct MintTokenData { |
There was a problem hiding this comment.
Такую структуру стоит перенести в nonfungible, и для refungible разрешить указывать произвольное число pieces
There was a problem hiding this comment.
В substrate у нас разрешено 2 вида минтинга: много токенов, один владелец
Один токен, много владельцев
Стоит в таком же формате обрабатывать минтинг, и можно переиспользовать бенчмарки (В теории можно разрешить много токенов * много владельцев, т.к это измеримо с помощью газа, но пока обойдёмся субстратными схемами).
fairax
force-pushed
the
feature/add_mint_bulk_cross
branch
from
33895cb to
7fd7521
Compare
fairax
force-pushed
the
feature/add_mint_bulk_cross
branch
from
7fd7521 to
0c121c7
Compare
CertainLach
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.