-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh... I did some things #418
base: master
Are you sure you want to change the base?
Conversation
…dingly, and put a try/catch block around one thing that was causing crashes.
Found a couple issues, the color chooser always goes to black, likely because I deleted the custom color chooser, and the export settings don't properly save, no idea why that is. Fixed both of these and commited to my fork. |
I'll try to have some time at monday to test this well. Does this also update version of VisUI? if so, does it break Color Picker? |
It looks pretty cool and we also have another branch internally with some things fixed, as well as Spine stuff updated. Maybe it may be a good idea to merge this all together, test and push as new version. I'll try to make time for this. |
I eliminated the customColorPicker class (yes, the new VisUI broke it, but it has its own color picker now), and related classes, used the stock VisUI color picker, and then fixed a minor bug from that. Basically what I did was change the versions in the build.gradle, attempt to compile, fix the errors it brought up, rinse, repeat until it worked, I also used the VisUI changelog to determine the correct thing to use in cases where classes were removed, like replacing NumberSelectors with Spinners. I did this over the course of a few hours with almost know deep knowledge of Overlap, OR VisUI codebases, as far as I can tell everything seems to work properly. |
This is an accept at your own risk courtesy request, I haphazardly updated everything to the latest libraries, and refactored where necessary... A couple things to note, the unit tests die horribly after completing successfully according to my IDE, a couple files seem to have been misplaced from the plugins directory (.gitignore), and I prevented a crash with a try/catch block in followersUiMediator, but I didn't actually do anything about it other than print out the fact that it happens.
Some files were removed entirely , mostly because I didn't know what they did and they were causing problems >.>
You might be better off to branch this, and fix up the things I likely trampled over, basically the entire point of this pull request is to make you aware of its existence, and not much else... The unit test problem may be because I deleted one of the tests, as it was testing a file that I also deleted >.> But I don't know much about unit testing...
Oh, and I didn't update the plugins, so they likely won't work...
This was an attempt to try to fix problems our level designer was having, his specific complaint was to do with the exception I added a try/catch block for, updating to latest libraries I assumed would generally improve stability, but honestly with all the refactoring that was required who knows at this point...
Call it an experimental build >.>