Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency between editor and flight behavior regarding Wolf depot creation #1570

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mhoram-kerbin
Copy link
Contributor

In the editor it is perfectly fine to attach a Wolf Depot and a Wolf Converter to the same ship.

However when one tries to establish a depot with such a vessel, one receives a message, that these parts can not be on the same ship.

There seem to be two solutions:

  • Change the behavior of the editor
  • Change the behavior during Depot-creation

This PR is a first step for implementing the second option.

This patch changes the behavior of Depot-creation in the following way:

  • allow Wolf-converters to be on the ship
  • allow Crew to be on the ship
  • after creating the depot, establish the converters and the crew to the Biome
  • in the case that the planning was incorrect, the converters get abandoned (*)

The this patch aims to leave the previous behavior for connecting converters the same.

(*) I am not quite happy with this behavior, but lack currently an idea for how to do this better. So I will leave this PR as a draft for the moment.

@zajc3w
Copy link
Contributor

zajc3w commented Dec 4, 2022

Not allowing o attach any onverter/crew to a depot would be a PITA when trying to establish wolf system in one launch.
Default behavior is fine, just have to remember to make depot detachable self contained unit with probe core, some EC and attachement computer.
IMHO Info in depot description in VAB/SPH in red would suffice.

@mhoram-kerbin
Copy link
Contributor Author

@zajc3w I am not sure if I understand you correctly. The idea of the PR was to allow mixing depot, crew and converters in a single ship, so that all gets deployed in a single step without the need to detach parts of the ship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants