Fix an exception during connecting to depot with complex ships #1567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more complex vessels I experienced the strange behavior, that during connection to a depot, only parts of the ship were destroyed and other parts left as debris in place. This also had the effect that I lost reputation from all the killed Kerbals. The logs showed the following exception:
I was able to prevent this exception by reversing the order, in which parts get deleted. Currently the parts get deleted beginning with the root-part. This patch changes this so that the root part is deleted last.
Rationale: It seems like deleting a part with multiple children creates several distinct vessels before continuing to delete the other parts.