Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement datediff for for week days (DNA-24249: DNA-24526 + DNA-24512) #87

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

cverhoef
Copy link
Contributor

@cverhoef cverhoef commented Mar 26, 2024

Description

  • Update the existing datediff function to make consistent over databases,
    • Weeks are defined from Sunday to Saturday
    • Added the week, quarter, and month options to Databricks.
  • New function diff_weekdays is implemented to return number of days excluding weekends.

Release

  • Direct release (main)
  • Merge to dev (or other) branch
    • Why:

Did you consider?

  • Does it Work on Automation Suite / SQL Server
  • Does it Work on Automation Cloud / Snowflake
  • What is the performance impact?
  • The version number in dbt_project.yml

@cverhoef cverhoef marked this pull request as draft March 26, 2024 11:36
@cverhoef cverhoef changed the title feat: implement datediff_weekdays feat: implement datediff for for week days (DNA-24249: DNA-24526) Mar 26, 2024
@cverhoef cverhoef force-pushed the feat/datediff_working_days branch 2 times, most recently from 248508b to 5b28db8 Compare March 26, 2024 12:18
@cverhoef cverhoef force-pushed the feat/datediff_working_days branch from 6cc8357 to 826dedf Compare March 26, 2024 13:38
@cverhoef cverhoef changed the title feat: implement datediff for for week days (DNA-24249: DNA-24526) feat: implement datediff for for week days (DNA-24249: DNA-24526 + DNA-24512) Mar 26, 2024
@cverhoef cverhoef marked this pull request as ready for review March 26, 2024 13:39
@KosmasH KosmasH merged commit ced68f2 into main Mar 28, 2024
8 checks passed
@KosmasH KosmasH deleted the feat/datediff_working_days branch March 28, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants