Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include spaces in charindex macro for SQL Server DNA-15944 [DNA-20911] #83

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Include spaces in charindex macro for SQL Server DNA-15944 [DNA-20911] #83

merged 2 commits into from
Nov 20, 2023

Conversation

silviustanimir
Copy link
Contributor

@silviustanimir silviustanimir commented Nov 20, 2023 •
edited
Loading

Description

  • For the charindex macro, also account for spaces in SQL Server when checking if a field is null or not.

Release

  • Direct release (main)
  • Merge to dev (or other) branch
    • Why:

Did you consider?

  • Does it Work on Automation Suite / SQL Server
  • Does it Work on Automation Cloud / Snowflake
  • What is the performance impact?
  • The version number in dbt_project.yml

@silviustanimir silviustanimir self-assigned this Nov 20, 2023
@silviustanimir silviustanimir merged commit ba72884 into main Nov 20, 2023
4 checks passed
@silviustanimir silviustanimir deleted the fix/charindex_sql_server branch November 20, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dennis-UiPath Dennis-UiPath Dennis-UiPath approved these changes

Assignees

@silviustanimir silviustanimir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silviustanimir @Dennis-UiPath