Rudimentary geolocation #223
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added basic class we can build on and just copied the unit tests for now
Fixed imports and moved files in right folders
…e it more rudimentary
Xierumeng
reviewed
Nov 13, 2024
| @@ -0,0 +1,71 @@ | |||
| """ | |||
| Converts image space into world space in a more rudimentary sense | |||
There was a problem hiding this comment.
What does rudimentary sense mean?
|
|
||
| from .. import detection_in_world | ||
| from .. import merged_odometry_detections | ||
| from .geolocation import Geolocation |
There was a problem hiding this comment.
Remove. Rudimentary geolocation should be able to work even if geolocation.py is deleted.
| from .geolocation import Geolocation | ||
|
|
||
|
|
||
| class RudimentaryGeolocation(Geolocation): |
| dtype=np.float32, | ||
| ) | ||
|
|
||
| result, perspective_transform_matrix = self.__get_perspective_transform_matrix( |
There was a problem hiding this comment.
This is overkill and defeats the purpose of the task. Pull __ground_intersection_from_vector() and other required helper functions into a separate file, and import that instead.
| # Get Pylance to stop complaining | ||
| assert perspective_transform_matrix is not None | ||
|
|
||
| # pylint: disable=duplicate-code |
There was a problem hiding this comment.
Disabling the Pylint must include an explanation as comment.
Also, linter must be reenabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rudimentary version of Geolocation