Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded the number of characters in the part of the vic2netcdf.py #17

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

orianac
Copy link
Member

@orianac orianac commented Jul 17, 2015

code that reads filenames to find the coordinates. Before, the
code would break if the output files were at 1/16th degree resolution
because the number of characters of a XX.XXXXX_-XXX.XXXXX would
exceed the counted characters and the coordinate mapping would
fail.

code that reads filenames to find the coordinates. Before, the
code would break if the output files were at 1/16th degree resolution
because the number of characters of a XX.XXXXX_-XXX.XXXXX would
exceed the counted characters and the coordinate mapping would
fail.
@jhamman
Copy link
Member

jhamman commented Jul 17, 2015

Thanks but I think the better way to approach this is to make this a option in the config file. I'll leave this open but I think it will require a bit more work.

@jhamman
Copy link
Member

jhamman commented Jul 17, 2015

@orianac -

This should push you in the right direction:

tuple(map(float, os.path.splitext(os.path.basename(filename))[0].split('_')[-2:]))

We want to test this though so if you could add a few short tests to the get_file_coords, that would put this issue to bed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants