-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI #16
Add CI #16
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #16 +/- ##
=========================================
Coverage ? 62.40%
=========================================
Files ? 35
Lines ? 4543
Branches ? 0
=========================================
Hits ? 2835
Misses ? 1708
Partials ? 0 ☔ View full report in Codecov by Sentry. |
d347dd5
to
31fdc07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way that python errors is handled right now is in my opinion really suboptimal. We should pretty-print the underlying error with a explanatory message leading and following it rather than just swallowing the exception, printing a generic error, and continuing.
a46219e
to
0b5e599
Compare
0b5e599
to
f892ee4
Compare
FWIW, I think that this is a good example of a pull request that should be multiple commits; the changes being done are touching several different concerns (i.e. catching pyplot errors vs. setting up the CI itself) and having those be in separate commits. Regardless, I think it's good to go. |
Resolves Issue #15
Added CI and codecoverage.
Added error handling for plotting in unit tests.