Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI #16

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Add CI #16

merged 1 commit into from
Aug 7, 2023

Conversation

govindchari
Copy link
Member

Resolves Issue #15

Added CI and codecoverage.

Added error handling for plotting in unit tests.

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@7c20950). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 0b5e599 differs from pull request most recent head f892ee4. Consider uploading reports for the commit f892ee4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage          ?   62.40%           
=========================================
  Files             ?       35           
  Lines             ?     4543           
  Branches          ?        0           
=========================================
  Hits              ?     2835           
  Misses            ?     1708           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@BenChung BenChung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way that python errors is handled right now is in my opinion really suboptimal. We should pretty-print the underlying error with a explanatory message leading and following it rather than just swallowing the exception, printing a generic error, and continuing.

test/examples/double_integrator/tests.jl Show resolved Hide resolved
@govindchari govindchari force-pushed the feature/add-ci branch 6 times, most recently from a46219e to 0b5e599 Compare August 7, 2023 03:43
@BenChung
Copy link

BenChung commented Aug 7, 2023

FWIW, I think that this is a good example of a pull request that should be multiple commits; the changes being done are touching several different concerns (i.e. catching pyplot errors vs. setting up the CI itself) and having those be in separate commits. Regardless, I think it's good to go.

@govindchari govindchari merged commit d5b6691 into master Aug 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants