add ClientEventTime #245
Open
add ClientEventTime #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nl32
requested changes
Oct 8, 2024
There was a problem hiding this comment.
there are some unused imports causing the build to fail that need to be resolved.
I ran this on local and the formatting is wrong.
on dev it looks like this:
however on this branch it looks like this:
it should look like it does on dev, just with the right time.
| @@ -0,0 +1,34 @@ | |||
| 'use client'; | |||
| //import react | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
unnecessary import and comment
| timeZone: Intl.DateTimeFormat().resolvedOptions().timeZone, | ||
| }); | ||
|
|
||
| //resturn span element that dispalys local start and end time |
| ) : ( | ||
| <> - {format(event.endTime, 'E, MMM d, p')}</> | ||
| )} | ||
| {/* Use the ClientEventTime component here */} |
Comment on lines
+18
to
+24
| const localStartTime = new Date(startTime).toLocaleString(undefined, { | ||
| timeZone: Intl.DateTimeFormat().resolvedOptions().timeZone, | ||
| }); | ||
| //same | ||
| const localEndTime = new Date(endTime).toLocaleString(undefined, { | ||
| timeZone: Intl.DateTimeFormat().resolvedOptions().timeZone, | ||
| }); |
There was a problem hiding this comment.
not sure if this is necessary since it's a client component, you can play with it once it builds on vercel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a component "ClientEventTime" and integrated it into the EventCard component