Bita #7
Merged
Bita #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arashhs
requested changes
May 8, 2024
README.md
Outdated
| @@ -28,9 +28,9 @@ First, navigate to the project directory and install the necessary packages usin | |||
| 2. **Configure Database Properties:** | |||
| Copy the provided example configuration file to create your own configuration: | |||
There was a problem hiding this comment.
Actually this is no longer needed, bc the user should download the config sample file from dashboard setup page and upload the updated config there, not directly in the file system. Please update the setup part to reflect this.
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - bita |
There was a problem hiding this comment.
Let's only push the image from main branch so that the experimental new features are not added to docker image yet.
There was a problem hiding this comment.
I pushed my changes Arash, and I tested them. For the demo, please run the GitHub workflow to update the docker image from the main branch. I can only rerun jobs on my branch. Please review and merge next week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed some issues in the documentation regarding db access which caused me confusion when I started working on the toolkit.