Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds card liking button to cards #28

Closed
wants to merge 2 commits into from
Closed

Adds card liking button to cards #28

wants to merge 2 commits into from

Conversation

vipulroxx
Copy link
Contributor

@vipulroxx vipulroxx commented Oct 27, 2017

Adds like button and fixes word wrapping in the card container.
Screenshot:
changesvotebranch

  • Fixes the issue when the string in the card was larger than the width of the card.
  • Added a button to render the like.
  • Like button is disabled after it is clicked and the global state of total number of like of the particular card increments by 1.
  • Changed the position of the button to be aligned at the end of the card.

This closes #8.

…ent.

- Fixes the issue when the string in the card was larger than the width of the card.
- Added a button to render the like.
- Like button is disabled after it is clicked and the global state of total number of like of the particular card increments by 1.
- Changed the position of the button to be alligned at the end of the card.
@vipulroxx vipulroxx requested a review from floogulinc October 27, 2017 21:00
@floogulinc floogulinc changed the title Fixes word wrapping issue and adds a like instance to the card compon… Adds card liking button to cards Oct 27, 2017
Copy link
Member

@floogulinc floogulinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs testing for the added feature and the existing testing needs to be fixed. Also this doesn't update that the card was liked on the database.

- Checks whether the button is getting clicked.
- Checks whether the likes are getting incremented after it is clicked.
@floogulinc floogulinc closed this Nov 2, 2017
@EthanUphoff EthanUphoff deleted the vote branch November 7, 2017 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upvote/Downvote cards
2 participants