Added a note to the documentation stating that the similarity method does not support embeddings other than non-quantized ones. #3131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaarsen
reviewed
Dec 12, 2024
| @@ -723,14 +723,15 @@ def similarity_fn_name( | |||
| def similarity(self, embeddings1: Tensor, embeddings2: Tensor) -> Tensor: ... | |||
|
|
|||
| @overload | |||
| def similarity(self, embeddings1: ndarray, embeddings2: ndarray) -> Tensor: ... | |||
| def similarity(self, embeddings1: npt.NDArray[np.float32], embeddings2: npt.NDArray[np.float32]) -> Tensor: ... | |||
There was a problem hiding this comment.
Nice, looks to be the correct usage. I wasn't aware of these.
https://numpy.org/devdocs/reference/typing.html#numpy.typing.NDArray
|
Very nice work! Thanks for this.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved: #3121
Changes
If you find any issues or have concerns about these changes, please feel free to suggest adjustments.