Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Make MultipleNegativesRankingLoss easier to understand #3100

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

tomaarsen
Copy link
Collaborator

Hello!

Pull Request overview

  • Make MultipleNegativesRankingLoss easier to understand by renaming the variables and adding a bunch of comments.

Details

Because this is one of the most common loss functions, I think it's useful to comment-spam it a bit - it might inspire some people to experiment with variations.

  • Tom Aarsen

Because this is one of the most common loss functions, I think it's useful to comment-spam it a bit.
@tomaarsen tomaarsen requested a review from Copilot December 2, 2024 12:25

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

@tomaarsen tomaarsen merged commit ba8cb2e into UKPLab:master Dec 2, 2024
9 checks passed
@tomaarsen tomaarsen deleted the enh/clarify_mnrl branch December 2, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant