normalize to float in NanoBEIREvaluator, InformationRetrievalEvaluator, MSEEvaluator #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Very nice work - I love small but impactful fixes like these.
|
|
Hiya @tomaarsen Should we revert them back since it looks kinda ugly? |
|
That sounds like a good idea, indeed. Good thinking.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found NanoBEIREvaluator, InformationRetrievalEvaluator, MSEEvaluator returning a mix of np.floats and native floats.
I zeroed in on the issue and found that the 'prefix_name_to_metrics' was causing the problem, this simple fix just converts to floats the value element while destructing the dictionary.
Fixes #3093
@tomaarsen