add MCC to BinaryClassificationEvaluator #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logger.info(f"Accuracy with {name}: {acc * 100:.2f}\t(Threshold: {acc_threshold:.4f})") | ||
| logger.info(f"F1 with {name}: {f1 * 100:.2f}\t(Threshold: {f1_threshold:.4f})") | ||
| logger.info(f"Precision with {name}: {precision * 100:.2f}") | ||
| logger.info(f"Recall with {name}: {recall * 100:.2f}") | ||
| logger.info(f"Average Precision with {name}: {ap * 100:.2f}\n") | ||
| logger.info(f"Matthews Correlation with {name}: {mcc:.4f}\n") |
There was a problem hiding this comment.
Hi @JINO-ROHIT ,
I think you could also add this output to the docstring of the BinaryClassificationEvaluator class.
reissaavedra
approved these changes
Nov 12, 2024
|
@tomaarsen gentle ping to have a look |
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
|
Hello! I had a quick look and made some small nitpicks, all related to the logs/docstring. Beyond that, it looks solid to me. Well done, thanks for this @JINO-ROHIT, and thanks for the review @reissaavedra I'll merge this once the tests go green.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR links #3027 and adds the Matthews correlation coefficient.
Who can review?
@tomaarsen