Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cache even if module.json is not present in the cache. #1923

Closed
wants to merge 1 commit into from

Conversation

CharlesJu1
Copy link

Fix issus #1461. Pull #1565 checks whether module.json exist in the cache, which causes downloading from hub every time as there is no module.json from the hub.

@tomaarsen
Copy link
Collaborator

Hello!

#2345 has refactored the model loading, so this PR is no longer relevant I'm afraid. I'll be closing it. I do want to thank you for taking the time to make this PR, it was part of the inspiration for #2345.

  • Tom Aarsen

@tomaarsen tomaarsen closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants