Fix to issue #1760 #1868
Closed
Fix to issue #1760 #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed to issue[UKPLab#1760] of uploading the model to HuggingFace Hub
|
I can confirm that this PR fixes the issue. |
|
any updates on this? |
|
Any updates on when this will be merged? It's a rather critical issue |
|
Hey, still need this fix please!!!! |
|
Hello! #2376 has resolved this issue, while preserving backwards compatibility. It will be released in the next Sentence Transformers 2.3.0 release. Thanks for pointing me to this problem via this PR!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to issue #1760