Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded HF endpoint #1767

Closed
wants to merge 1 commit into from

Conversation

Wauplin
Copy link

@Wauplin Wauplin commented Nov 28, 2022

Currently, HF endpoint (e.g. https://huggingface.co) is hard-coded in sentence-transformers. This is problematic as it is not possible to configure it to save models from a different endpoint. In huggingface_hub it is possible to set a default endpoint using the HF_ENDPOINT environment variable. This is especially useful in testing pipelines and for users using a private Hub.

This PR removes the hard-coded endpoint and makes it configurable by huggingface_hub directly.
Also the full_model_name is not required anymore since #1743 as the repo_id is correctly inferred from model name and organization.

@Wauplin
Copy link
Author

Wauplin commented Nov 28, 2022

For context, we started to add tests from downstream libraries (like sentence_transformers) directly in huggingface_hub main repo -see PR huggingface/huggingface_hub#1200. The goal is to proactively detect breaking changes / deprecation warnings and report issues here if any.

@tomaarsen
Copy link
Collaborator

tomaarsen commented Dec 18, 2023

Resolved via #2376, the typo fix was taken into #2387. Thanks a bunch for reporting this & opening this PR!

Also made a new related PR here: huggingface/huggingface_hub#1918

  • Tom Aarsen

@tomaarsen tomaarsen closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants