Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FontAwesome instructions #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

belenbarrospena
Copy link

@belenbarrospena belenbarrospena commented Nov 26, 2016

Add Spanish translations, explain the dependency on FontAwesome and explain how to install the font in your system.

Signed-off-by: Belen Pena [email protected]

The poster svg files are using FontAwesome. If you don't have that font in your system,
some of the graphics will not render correctly.

Add a note to the help files about the FontAwesome requirement and some instructions
on how to install the font.

Signed-off-by: Belen Pena <[email protected]>
This commit adds Spanish to the list of translations currently available for the
Home Office Digital "Designing for Accessibility" posters.

Signed-off-by: Belen Pena <[email protected]>
Copy link
Contributor

@ei8fdb ei8fdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this information makes sense to add.

@karypun
Copy link
Contributor

karypun commented Dec 14, 2016

Hi @belenbarrospena
Sorry for the delay in getting back to you. Thanks for the FontAwesome instructions. However, I can't merge the pull request due to a conflict with another Spanish version with the same name that's already up there. My question to you is:

  1. Are there regional differences between yours and the ones that's already there ?
  2. If so, we may need to distinguish the different versions so we don't override the other.

Then it would be possible to merge the PR. Thank you!

@belenbarrospena
Copy link
Author

belenbarrospena commented Dec 19, 2016

Hi there,

Thanks for coming back to me. I think the other Spanish translation PR was sent before mine but not merged, and I didn't realise it was already submitted. My bad: I should have checked the list of PRs before sending mine.

I can separate the FontAwesome instructions and create a new PR.

Regarding the Spanish translation, I think it's really good, and as the author says it is neutral enough to stay as the only Spanish translation. However, it contains a few ortographical errors and I have some small comments:

  • All posters: the affirmative adverb carries a graphical accent in Spanish. It should be "Sí" (http://dle.rae.es/?id=XmOP8Ia|XmQKxT2) instead of "Si" (http://dle.rae.es/?id=XmM8PPL|XmMshCc)

  • All posters: in the licensing text, "esta" should say "está"

  • In deaf_es and dyslexia_es: in Spanish from Spain is "vídeo" and "vídeos" instead of "video" and "videos", although the latter is valid in Latin America (http://dle.rae.es/?id=bm7DOSs)

  • In low-vision_es: "tamaño" is masculine, so it should say "un tamaño" instead of "una tamaño"

  • In deaf_es: the plurar of "menú" is "menús", not "menúes" (http://lema.rae.es/dpd/srv/search?key=men%FA)

  • In deaf_es: it should be "vía" instead of "via" (http://dle.rae.es/?id=biXBkO2)

  • In motor-disabilities_es: "clickeables" is not a word. I know what the author means, but still, it is not a word. I translated that as "usar acciones y enlaces grandes". The author's translation is perfectly understandable though, even if not fully correct.

  • In motor-disabilities_es: "presición" should be "precisión"

  • In motor-disabilities_es: "mouse" should be translated as "ratón" (http://dle.rae.es/?id=VEOs7fW). No need to use the English form.

  • In motor-disabilities_es: "tipear" is only valid in Latin America, and "scroll" is not a word. I would suggest rewriting. I translated as: "requerir demasiada información y desplazamientos en pantalla".

  • In motor-disabilities_es: the translation "tener períodos de expiración de una tarea" doesn't seem to reflect the original meaning. The translation says no session expiring should be used, but the original seems to say that session expiring is ok as long as enough time is provided. I would recommend reviewing to better reflect the original meaning, particularly since session expiring is a security feature, and we don't want to pitch accessibility against security.

This is what I would do:

  1. close this pr without merging. I will send a new one with only the Font Awesome changes
  2. contact the original author and ask her wether she would be willing to consider the list of changes above and send a new PR

@belenbarrospena
Copy link
Author

Sorry, didn't mean to close, just comment on it :) Reopening

@karypun
Copy link
Contributor

karypun commented Dec 19, 2016

@lopezbreit Hello!

Is it possible for you to review the suggestions @belenbarrospena sent above and work together to send a new PR? Appreciate the feedback on this @belenbarrospena :)

Thanks.

@lopezbreit
Copy link
Contributor

Sure, @karypun . Hi, @belenbarrospena I´ll be taking a look at your post.

@lopezbreit
Copy link
Contributor

lopezbreit commented Jan 4, 2017

Hi,@belenbarrospena
First, many thanks for your review! I did all the changes and believe we can achieve a version that supports both Spain and Latin America.
Please review them and when we are ready I´ll send a new PR to @karypun .
Thanks again!
Tam

Posters with the reviews:
All-posters_ES_04012017.pdf

Details:
1. Done as it was suggested:
• All posters: the affirmative adverb carries a graphical accent in Spanish. It should be "Sí" (http://dle.rae.es/?id=XmOP8Ia|XmQKxT2) instead of "Si" (http://dle.rae.es/?id=XmM8PPL|XmMshCc)
• All posters: in the licensing text, "esta" should say "está"
• In low-vision_es: "tamaño" is masculine, so it should say "un tamaño" instead of "una tamaño"
• In deaf_es: the plurar of "menú" is "menús", not "menúes" (http://lema.rae.es/dpd/srv/search?key=men%FA)
• In deaf_es: it should be "vía" instead of "via" (http://dle.rae.es/?id=biXBkO2)
• In motor-disabilities_es: "clickeables" is not a word. I know what the author means, but still, it is not a word. I translated that as "usar acciones y enlaces grandes". The author's translation is perfectly understandable though, even if not fully correct.
• In motor-disabilities_es: "presición" should be "precisión"
I do understand this and did the change! although in the spoken or written communications no one here uses ¨ratón¨.
• In motor-disabilities_es: "mouse" should be translated as "ratón" (http://dle.rae.es/?id=VEOs7fW). No need to use the English form.
Also here, used the translation suggested so it would fit Spain and Latin America.
• In motor-disabilities_es: "tipear" is only valid in Latin America, and "scroll" is not a word. I would suggest rewriting. I translated as: "requerir demasiada información y desplazamientos en pantalla".

2. For this one I just added the word ¨breve¨ to make sure we reflect the original meaning.
• In motor-disabilities_es: the translation "tener períodos de expiración de una tarea" doesn't seem to reflect the original meaning. The translation says no session expiring should be used, but the original seems to say that session expiring is ok as long as enough time is provided. I would recommend reviewing to better reflect the original meaning, particularly since session expiring is a security feature, and we don't want to pitch accessibility against security.

3. Do you agree on creating a different version for Spain Only for this poster?:
• In deaf_es and dyslexia_es: in Spanish from Spain is "vídeo" and "vídeos" instead of "video" and "videos", although the latter is valid in Latin America (http://dle.rae.es/?id=bm7DOSs)

@belenbarrospena
Copy link
Author

Hi @lopezbreit

Sorry for the delay in getting back to you: I was traveling for a while. Thank you so much for the changes: I agree with them all.

Regarding 3, I think is too small an issue to grant a different poster. Let's leave it as "video": I honestly can't imagine any Spaniards complaining about this :)

Cheers

Belén

@lopezbreit
Copy link
Contributor

HI @belenbarrospena, Many thanks for your reply!
Hi @karypun, I will be sending a new PR shortly!

Best!
Tam

@karypun
Copy link
Contributor

karypun commented Jun 22, 2017

@belenbarrospena @lopezbreit I can't merge the PR as there's conflicts that need to be resolved first which is preventing me from merging. Are you able to fix this? Thanks.

@TheaLemon
Copy link

Hi, Bolagsverket (the Swedish Companies Registration Office) have translated the posters to swedish how do I upload them so more people from sweden can use them?

All the best! :)

low-vision_SE.pdf
motor-disabilities_SE.pdf
screenreader_SE.pdf
autistic-spectrum_SE.pdf
cover_SE.pdf
deaf_SE.pdf
dyslexia_SE.pdf

@karypun
Copy link
Contributor

karypun commented Jul 20, 2017

@TheaLemon I've put your poster translation to issue 57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants