Add decision tree to Behavior README #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaredycode
changed the title
has no effect on functionality, other than getting rid of the possibility to get a fail when the 'stop' command is issued before a successful read, which is suboptimal and will be fixed here :)
scaredycode
requested review from
iibrahimli,
berkgungor,
yl-wang996 and
cvhex
Juphex
reviewed
Oct 16, 2023
| @@ -369,24 +387,6 @@ def callback_command(self, command_msg): | |||
| rospy.logwarn('The audio preview is already playing.') | |||
| self.response_pub.publish('The audio preview is already playing.') | |||
|
|
|||
| elif command_msg.behavior == "stop": | |||
There was a problem hiding this comment.
Why did you change this? @scaredycode
There was a problem hiding this comment.
To match the decision tree. It has no negative effects on the functionality. A positive effect is that we will no longer get the "No notes to play" Response for using the 'stop' command before a successful 'read'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added decision tree