Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the lower notes for sharps #283

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Use the lower notes for sharps #283

merged 6 commits into from
Oct 12, 2023

Conversation

Flova
Copy link
Collaborator

@Flova Flova commented Oct 5, 2023

PR #281 adds new hit points and this PR utilizes them in the motion.

@Flova
Copy link
Collaborator Author

Flova commented Oct 5, 2023

This is totally untested as of now and waits for #281

@iibrahimli
Copy link
Collaborator

LG if either ends_with is implemented, or we switch to C++ 20 :D

Copy link
Member

@Juphex Juphex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Flova
Copy link
Collaborator Author

Flova commented Oct 10, 2023

Well the old CPP version strikes again...
We can use the boost ends_with tho. similar to the boost optional we are using.

@berkgungor
Copy link
Collaborator

I know it is a different PR, but I also pushed changes that enable the preemption / canceling of a running action.

Copy link
Collaborator

@yl-wang996 yl-wang996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@berkgungor berkgungor merged commit 7966dfa into main Oct 12, 2023
2 checks passed
@Juphex Juphex deleted the use_lower_notes_motion branch October 12, 2023 17:02
@Juphex Juphex restored the use_lower_notes_motion branch October 12, 2023 17:02
@Juphex Juphex deleted the use_lower_notes_motion branch October 12, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants