Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add conventional commit checker #19

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

ObstinateM
Copy link
Contributor

Contributor: Mathis Beauville

Description: This pull request adds a new job to the existing GitHub Actions workflow to ensure that all commits follow the "Conventional Commit" format. The commit types are dynamically loaded from a commit_type.json file, allowing for easy customization and future scalability.

Main Changes:

  • Added a new job to the existing GitHub Actions workflow to check commit messages.
  • Integrated a custom python script to check commit message.
  • Commit types are loaded from a commit_type.json file, making it easier to update and manage allowed types.

Linked Issue: #6

Testing:

The new job was tested to ensure proper validation of commit messages and correct loading of commit types from commit_type.json.
If a commit doesn't comply with the specified format, the workflow will fail, and an error message will be returned. (see test/failing branch)

Instructions:

After this PR is merged, contributors must ensure that their commits follow the "Conventional Commit" format, with types as defined in commit_type.json. Non-compliant commits will result in PR failure during validation.

@SMoraisDev
Copy link
Contributor

On échangera sur cette PR pendant la prochaine séance, ne touche plus a rien stp :)

Copy link
Collaborator

@SebastienMorais SebastienMorais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Très bon travail ! Peux-tu utiliser des versions d'action plus récentes ?
Soucis de conflit :)

@ObstinateM ObstinateM force-pushed the main branch 2 times, most recently from b1d47f5 to 3947a07 Compare October 9, 2024 11:10
ci: add new ci to current ci jobs

fix: linting error related to new CI

ci: clean the code

chore: add contributor

ci: fix linting errors

ci: fix error when PR from fork

ci: fix linting errors
@SMoraisDev SMoraisDev merged commit 9f2e857 into UEVE-DLL-2024-2025:main Oct 9, 2024
4 checks passed
alexandreantunesmnds pushed a commit to alexandreantunesmnds/DLL that referenced this pull request Oct 9, 2024
* ci: add base script to check conventional commits

* CI: Add conventional commit checker

ci: add new ci to current ci jobs

fix: linting error related to new CI

ci: clean the code

chore: add contributor

ci: fix linting errors

ci: fix error when PR from fork

ci: fix linting errors
alexandreantunesmnds pushed a commit to alexandreantunesmnds/DLL that referenced this pull request Oct 9, 2024
* ci: add base script to check conventional commits

* CI: Add conventional commit checker

ci: add new ci to current ci jobs

fix: linting error related to new CI

ci: clean the code

chore: add contributor

ci: fix linting errors

ci: fix error when PR from fork

ci: fix linting errors
JML-0 pushed a commit to JML-0/DLL that referenced this pull request Oct 9, 2024
CI: Add pylint workflow

CHORE: Update README.md

FEATURE: Add slides' early version

FEATURE: Add authors file

DOCS: Add documentation

CHORE: Add docs dependencies

FIX: Doc build in CI

FIX: Doc deploy in CICD

FIX: Avoid decompressing artifact

CI: Deploy only from main

FIX: Doc deploy step

FIX: permissions access of doc deploy

CI: Publish version/dev

FIX: Permissions of doc deploy job

FIX: Permissions of doc deploy job

CHORE: Add version value

CHORE: Add template forcontribution

CHORE: Bump dev version into v0.2.dev0

FEATURE: Add slide content (UEVE-DLL-2024-2025#10)

CHORE: Add slide on security (UEVE-DLL-2024-2025#11)

CI: fixing pylint issues occuring at CI pipeline (UEVE-DLL-2024-2025#12)

BUG : fix game without end (UEVE-DLL-2024-2025#14)

* BUG: fix game withoud end

* edit AUTHORS.md

BUG: Nombre de mines invalide (UEVE-DLL-2024-2025#15)

* update contributors

* FIX:Nombre de mines invalide

---------

Co-authored-by: marwane rachad <[email protected]>

CI: Add conventional commit checker (UEVE-DLL-2024-2025#19)

* ci: add base script to check conventional commits

* CI: Add conventional commit checker

ci: add new ci to current ci jobs

fix: linting error related to new CI

ci: clean the code

chore: add contributor

ci: fix linting errors

ci: fix error when PR from fork

ci: fix linting errors
Sebb955 pushed a commit to Sebb955/DLL that referenced this pull request Oct 14, 2024
* ci: add base script to check conventional commits

* CI: Add conventional commit checker

ci: add new ci to current ci jobs

fix: linting error related to new CI

ci: clean the code

chore: add contributor

ci: fix linting errors

ci: fix error when PR from fork

ci: fix linting errors
Sebb955 pushed a commit to Sebb955/DLL that referenced this pull request Oct 14, 2024
* ci: add base script to check conventional commits

* CI: Add conventional commit checker

ci: add new ci to current ci jobs

fix: linting error related to new CI

ci: clean the code

chore: add contributor

ci: fix linting errors

ci: fix error when PR from fork

ci: fix linting errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants