-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add conventional commit checker #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On échangera sur cette PR pendant la prochaine séance, ne touche plus a rien stp :) |
SebastienMorais
requested changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Très bon travail ! Peux-tu utiliser des versions d'action plus récentes ?
Soucis de conflit :)
SMoraisAnsys
reviewed
Oct 8, 2024
ObstinateM
force-pushed
the
main
branch
2 times, most recently
from
October 9, 2024 11:10
b1d47f5
to
3947a07
Compare
ci: add new ci to current ci jobs fix: linting error related to new CI ci: clean the code chore: add contributor ci: fix linting errors ci: fix error when PR from fork ci: fix linting errors
alexandreantunesmnds
pushed a commit
to alexandreantunesmnds/DLL
that referenced
this pull request
Oct 9, 2024
* ci: add base script to check conventional commits * CI: Add conventional commit checker ci: add new ci to current ci jobs fix: linting error related to new CI ci: clean the code chore: add contributor ci: fix linting errors ci: fix error when PR from fork ci: fix linting errors
alexandreantunesmnds
pushed a commit
to alexandreantunesmnds/DLL
that referenced
this pull request
Oct 9, 2024
* ci: add base script to check conventional commits * CI: Add conventional commit checker ci: add new ci to current ci jobs fix: linting error related to new CI ci: clean the code chore: add contributor ci: fix linting errors ci: fix error when PR from fork ci: fix linting errors
JML-0
pushed a commit
to JML-0/DLL
that referenced
this pull request
Oct 9, 2024
CI: Add pylint workflow CHORE: Update README.md FEATURE: Add slides' early version FEATURE: Add authors file DOCS: Add documentation CHORE: Add docs dependencies FIX: Doc build in CI FIX: Doc deploy in CICD FIX: Avoid decompressing artifact CI: Deploy only from main FIX: Doc deploy step FIX: permissions access of doc deploy CI: Publish version/dev FIX: Permissions of doc deploy job FIX: Permissions of doc deploy job CHORE: Add version value CHORE: Add template forcontribution CHORE: Bump dev version into v0.2.dev0 FEATURE: Add slide content (UEVE-DLL-2024-2025#10) CHORE: Add slide on security (UEVE-DLL-2024-2025#11) CI: fixing pylint issues occuring at CI pipeline (UEVE-DLL-2024-2025#12) BUG : fix game without end (UEVE-DLL-2024-2025#14) * BUG: fix game withoud end * edit AUTHORS.md BUG: Nombre de mines invalide (UEVE-DLL-2024-2025#15) * update contributors * FIX:Nombre de mines invalide --------- Co-authored-by: marwane rachad <[email protected]> CI: Add conventional commit checker (UEVE-DLL-2024-2025#19) * ci: add base script to check conventional commits * CI: Add conventional commit checker ci: add new ci to current ci jobs fix: linting error related to new CI ci: clean the code chore: add contributor ci: fix linting errors ci: fix error when PR from fork ci: fix linting errors
Sebb955
pushed a commit
to Sebb955/DLL
that referenced
this pull request
Oct 14, 2024
* ci: add base script to check conventional commits * CI: Add conventional commit checker ci: add new ci to current ci jobs fix: linting error related to new CI ci: clean the code chore: add contributor ci: fix linting errors ci: fix error when PR from fork ci: fix linting errors
Sebb955
pushed a commit
to Sebb955/DLL
that referenced
this pull request
Oct 14, 2024
* ci: add base script to check conventional commits * CI: Add conventional commit checker ci: add new ci to current ci jobs fix: linting error related to new CI ci: clean the code chore: add contributor ci: fix linting errors ci: fix error when PR from fork ci: fix linting errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor: Mathis Beauville
Description: This pull request adds a new job to the existing GitHub Actions workflow to ensure that all commits follow the "Conventional Commit" format. The commit types are dynamically loaded from a
commit_type.json
file, allowing for easy customization and future scalability.Main Changes:
commit_type.json
file, making it easier to update and manage allowed types.Linked Issue: #6
Testing:
The new job was tested to ensure proper validation of commit messages and correct loading of commit types from commit_type.json.
If a commit doesn't comply with the specified format, the workflow will fail, and an error message will be returned. (see
test/failing
branch)Instructions:
After this PR is merged, contributors must ensure that their commits follow the "Conventional Commit" format, with types as defined in
commit_type.json
. Non-compliant commits will result in PR failure during validation.