Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse abstracts #88

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Collapse abstracts #88

wants to merge 10 commits into from

Conversation

Sean1572
Copy link
Contributor

No description provided.

@Sean1572 Sean1572 linked an issue May 18, 2024 that may be closed by this pull request
Copy link
Contributor

@ntlhui ntlhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source changes look good, @ntlhui to deploy local to review build

@Sean1572 Sean1572 marked this pull request as ready for review August 30, 2024 21:41
@Sean1572 Sean1572 marked this pull request as draft August 30, 2024 21:41
@Sean1572
Copy link
Contributor Author

One big thing is maybe styling could use work

Removed block that says abstract, clicking the title of the paper now opens abstract

Removed unnecessary padding

Note: not intuitive potentially, should think of UI design here
@Sean1572 Sean1572 requested review from ntlhui and ccrutchf August 30, 2024 22:21
@Sean1572 Sean1572 marked this pull request as ready for review September 2, 2024 19:56
@Sean1572 Sean1572 self-assigned this Sep 6, 2024
@Sean1572 Sean1572 enabled auto-merge (squash) September 19, 2024 17:17
@ntlhui
Copy link
Contributor

ntlhui commented Sep 24, 2024

The + is not immediately obvious.

Maybe a better styling might be an Abstract "button" between the citation and the DOI/HTTP/ArXiV links?

@Sean1572
Copy link
Contributor Author

The + is not immediately obvious.

Maybe a better styling might be an Abstract "button" between the citation and the DOI/HTTP/ArXiV links?

Interesting, let me take another look and maybe come up with a few ideas

@Sean1572
Copy link
Contributor Author

Sean1572 commented Sep 24, 2024

The + is not immediately obvious.

Maybe a better styling might be an Abstract "button" between the citation and the DOI/HTTP/ArXiV links?

Does this consider that hovering over the text makes the textbox highlighted and underlined?

edit: I agree the + is not immediately obvious. I think I'm going to bold it and make it bigger

@Sean1572
Copy link
Contributor Author

image

@ccrutchf ccrutchf marked this pull request as draft September 24, 2024 21:20
auto-merge was automatically disabled September 24, 2024 21:20

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapsible abstracts
2 participants