Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSG encoding and WARC page requisites fixes #244

Merged
merged 3 commits into from
Feb 7, 2024
Merged

MSG encoding and WARC page requisites fixes #244

merged 3 commits into from
Feb 7, 2024

Conversation

gwiedeman
Copy link
Collaborator

@gwiedeman gwiedeman commented Feb 7, 2024

Type of Contribution

  • Bugfix (non-breaking change which fixes an issue)
  • New component
  • Refactoring (no functional changes)
  • Documentation-only

What does this implement/fix? Explain your changes.

  • Handles encoding better for MSG source files by just relying on chardet
  • Improved injection of attached images in message HTML for HTML, PDF, and WARC derivatives
  • Fixes issue with --external-links not including requires CSS and JS in WARC derivatives

Link to issue?

n/a

  • Issue closed
  • Remain open

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • [] Make sure you are requesting to the develop branch. Don't PR to main!
  • This contribution has sufficient documentation
  • Tests for the changes have been added
  • All tests pass

How has this been tested?

Operating System: Win10
Python Version: 3.9.16

Licensing

  • I agree that the Mailbag Project and the University at Albany, SUNY can release this code under the MIT license.

@gwiedeman gwiedeman merged commit c650444 into main Feb 7, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant