-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monaco-languageclient config improvement, wrapper+languageclientwrapper improvements #741
Conversation
5b6fae2
to
62b8561
Compare
@CGNonofr some TODOs left, but generally the changes look good, some awkward behaviour of vitest browser mode: https://github.com/TypeFox/monaco-languageclient/blob/wrapper-improvements/packages/wrapper/test/languageClientWrapper.test.ts#L71-L79 |
- UserConfig is now WrapperConfig and one level less deep - Language client config has better names and is structured more logically - Introduce new two_langauge_clients.html example replacing wrapper_adv.html
45c7fc3
to
f4da090
Compare
@CGNonofr I may add more unit test, but feel free to review the changes. |
@CGNonofr any thoughts? I was not very active the last two weeks. This will change again next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admit I'm getting a bit lost in those libraries 😕
Feel being me, when looking at vast changes in monaco-vscode-api. 😆 |
This is ready from my side. I am already working on further improvements. WIP PR will come later and probably some questions, too. |
And another PR with update to mva 9.0.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello, I would like to add a 'typescript-language-server' example. Because I encountered an issue where I couldn't parse the workspace context while trying to use version 8.8.2, I would like to request a simple example to implement a language service for a JS project. thank you. |
Changes:
MonacoLanguageClient
:MessageTransports
are configured directly. This makes handling them easier in an application context or withLanguageClientWrapper
ConnetionConfigOptions
MonacoEditorLanguageClientWrapper
UserConfig
is nowWrapperConfig
and is one level less deep.LanguageClientWrapper
:LanguageClientWrapper
. Internal handling of the message transports has been improved.TODO: