Fixed PR comments

.eslintrc.js

@@ -25,7 +25,9 @@ module.exports = {
         'no-extra-semi': 'off',
         '@typescript-eslint/no-extra-semi': ['error'],
         'no-dupe-class-members': 'off',
-        'no-redeclare': 'warn',
+        '@typescript-eslint/no-dupe-class-members': ['error'],
+        'no-redeclare': 'off',
+        '@typescript-eslint/no-redeclare': ['error'],
         'no-useless-constructor': 'warn',
         'no-void': 'warn'
     }

.github/workflows/actions.yml

@@ -17,6 +17,6 @@ jobs:
     - name: Build
       shell: bash
       run: |
-        npm i
+        npm ci
         npm run build
         npm run lint

packages/client/src/monaco-language-client.ts

@@ -61,8 +61,8 @@ export class MonacoLanguageClient extends BaseLanguageClient {
                 registrations: params.registrations.filter(registration => this.getFeature(<any>registration.method) != null)
             });
         };
-        const originalHandleUnregistrationRequest: (params: UnregistrationParams) => Promise<void> = this['handleRegistrationRequest'].bind(this);
-        this['handleRegistrationRequest'] = (params: UnregistrationParams) => {
+        const originalHandleUnregistrationRequest: (params: UnregistrationParams) => Promise<void> = this['handleUnregistrationRequest'].bind(this);
+        this['handleUnregistrationRequest'] = (params: UnregistrationParams) => {
             originalHandleUnregistrationRequest({
                 ...params,
                 unregisterations: params.unregisterations.filter(unregistration => this.getFeature(<any>unregistration.method) != null)

packages/examples/browser-lsp/package.json

@@ -10,6 +10,7 @@
   },
   "scripts": {
     "clean": "npx shx rm -fr dist tsconfig.tsbuildinfo",
+    "lint": "echo 'No linting yet'",
     "compile": "tsc",
     "watch": "tsc -w",
     "copy:monacoworkers": "shx mkdir -p dist && shx cp -r ../../../node_modules/monaco-editor-workers/dist/workers/editorWorker* ./dist",

packages/vscode-ws-jsonrpc/package.json

@@ -28,6 +28,7 @@
   },
   "scripts": {
     "clean": "npx shx rm -fr lib tsconfig.tsbuildinfo",
+    "lint": "eslint src --ext .ts",
     "compile": "tsc",
     "watch": "tsc -w",
     "build": "npm run clean && npm run compile"