Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metamask as wallet options #113

Closed
wants to merge 4 commits into from
Closed

Metamask as wallet options #113

wants to merge 4 commits into from

Conversation

paulfears
Copy link

@paulfears paulfears commented Sep 27, 2023

Description

Added a metamask client as a wallet options.

Checklist

Please, make sure to comply with the checklist below before expecting review

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@drichar
Copy link
Collaborator

drichar commented Oct 5, 2023

Hi @paulfears, thank you for resubmitting your pull request. There are TypeScript errors preventing CI checks from passing (see below). Also, another pull request was just merged that introduced some minor conflicts on your branch, which should be pretty easy to fix.

I edited the pull request description to restore the template we use for contributions. Please run yarn check-types locally before pushing your commit(s) to be sure there are no TypeScript errors in your changes.

If you have any questions let me know. Thanks!

@drichar
Copy link
Collaborator

drichar commented Oct 30, 2023

@paulfears Any update(s) on this?

@SilentRhetoric
Copy link
Contributor

Hey @paulfears, may I ask if this is something you are planning to complete?

@drichar
Copy link
Collaborator

drichar commented Jan 25, 2024

Closing this due to inactivity. Please open a new pull request @paulfears if/when you're ready to revisit this feature.

@drichar drichar closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants