Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml serialisation - initial commit #307

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

mintel1
Copy link
Collaborator

@mintel1 mintel1 commented May 12, 2024

First commit just to get things up and running. This does not compile and has no rapidyaml - specific code yet.
What I've done is attempt to

  • get rapidyaml into the build via conan and cmake - docs on conan.io are pretty clear IMO
  • add in yaml specific reader, writer, exception files into the repo based purely on rapidjson with a lot of find and replace

At the moment, my main issues are that

  • the build doesn't take all of the new yaml* files into account
  • ryml::ryml and the rhyme headers are not recognised

If I can get the config correct so that ryml is recognised, I can start to look at how that lib differs from rapidjson and write code accordingly. It also means I could start looking at other potential serialisations :-)
Thanks!

@mintel1 mintel1 added enhancement New feature or request build Issue related to build system infrastructure serialisation Issues related to serialisation labels May 12, 2024
@mintel1 mintel1 requested a review from Twon May 12, 2024 09:10
@mintel1 mintel1 self-assigned this May 12, 2024
@mintel1
Copy link
Collaborator Author

mintel1 commented May 12, 2024

I will of course happily adhere to all of the coding guidelines (such as removal of commented out code etc) once I get things to a more presentable state. Also wondering if it could be possible to raise a PR without kicking off the checks, if I know it's going to fail anyway?

@Twon
Copy link
Owner

Twon commented May 12, 2024

I will of course happily adhere to all of the coding guidelines (such as removal of commented out code etc) once I get things to a more presentable state. Also wondering if it could be possible to raise a PR without kicking off the checks, if I know it's going to fail anyway?

Yes, you can mark this as a draft request. It's possible to change an existing PR to a draft one (just Google for how): https://github.blog/2019-02-14-introducing-draft-pull-requests/

@mintel1 mintel1 marked this pull request as draft May 12, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issue related to build system infrastructure enhancement New feature or request serialisation Issues related to serialisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants