-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[After #443] Feature: add filtering support for twingate_users datasource #456
Merged
bertekintw
merged 40 commits into
Twingate:main
from
vmanilo:feature/add-filtering-support-for-twingate_users-datasource
Feb 20, 2024
Merged
[After #443] Feature: add filtering support for twingate_users datasource #456
bertekintw
merged 40 commits into
Twingate:main
from
vmanilo:feature/add-filtering-support-for-twingate_users-datasource
Feb 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tasource' into feature/add-filtering-support-for-twingate_users-datasource
…ng-support-for-twingate_resources-datasource
…tasource' into feature/add-filtering-support-for-twingate_users-datasource
…esources-datasource
…esources-datasource
…ng-support-for-twingate_users-datasource
…esources-datasource
…ng-support-for-twingate_users-datasource
…ng-support-for-twingate_users-datasource
vmanilo
changed the title
Feature: add filtering support for twingate_users datasource
[After #443] Feature: add filtering support for twingate_users datasource
Jan 18, 2024
…esources-datasource
…urce' of github.com:vmanilo/terraform-provider-twingate into feature/add-filtering-support-for-twingate_users-datasource
…r-twingate_resources-datasource' into feature/add-filtering-support-for-twingate_users-datasource
…esources-datasource
…esources-datasource
twingate-blee
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…esources-datasource
…r-twingate_resources-datasource' into feature/add-filtering-support-for-twingate_users-datasource
…ng-support-for-twingate_users-datasource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #437
Tests passes: https://github.com/vmanilo/terraform-provider-twingate/actions/runs/7574865850
Changes