Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: create twingate-connector with disabled status #453

Conversation

vmanilo
Copy link
Contributor

@vmanilo vmanilo commented Jan 16, 2024

Resolves issue with creating new connector with disabled status

Tests passes: https://github.com/vmanilo/terraform-provider-twingate/actions/runs/7547395908

Changes

  • passing optional parameter status_updates_enabled on creation
  • added acc test

@vmanilo vmanilo requested a review from a team as a code owner January 16, 2024 21:07
Copy link
Contributor

@romankor romankor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gtm

Copy link
Member

@twingate-blee twingate-blee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bertekintw bertekintw merged commit e0c21cc into Twingate:main Jan 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants