Feature: add filtering support for twingate resources datasource #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmanilo
requested review from
a team,
ekampf,
liorr and
romankor
as code owners
…ng-support-for-twingate_resources-datasource
…esources-datasource
…esources-datasource
…esources-datasource
…esources-datasource
…esources-datasource
…esources-datasource
…esources-datasource
…esources-datasource
bertekintw
added a commit
that referenced
this pull request
Feb 20, 2024
…445) * added new attributes for resources datasource * added optional name attributes for resources datasource * added feature branch * fix test * remove feature branch * enable tests * remove feature branch * added filtering by name for service_accounts datasource * remove feature branch * refactore * updated docs * updated docs * update resources datasource: allow to list all resources * fix docs --------- Co-authored-by: bertekintw <[email protected]>
bertekintw
added a commit
that referenced
this pull request
Feb 20, 2024
…icies data source (#457) * added new attributes for resources datasource * added optional name attributes for resources datasource * added feature branch * fix test * remove feature branch * enable tests * remove feature branch * refactore * updated docs * update resources datasource: allow to list all resources * added filter options for security_policy datasource * enable test * revert ci changes * fix docs * fixed docs --------- Co-authored-by: bertekintw <[email protected]>
bertekintw
added a commit
that referenced
this pull request
Feb 20, 2024
…source (#458) * added new attributes for resources datasource * added optional name attributes for resources datasource * added feature branch * fix test * remove feature branch * enable tests * remove feature branch * refactore * updated docs * update resources datasource: allow to list all resources * wip * fix docs * added optional filters for twingate_remote_networks datasource * enable test * enable test * revert sweeper changes * run only datasource tests * fix users basic test * revert test.sh * fix users test * revert ci.yml * added example for remote_networks datasource --------- Co-authored-by: bertekintw <[email protected]>
bertekintw
added a commit
that referenced
this pull request
Feb 20, 2024
…ource (#463) * added new attributes for resources datasource * added optional name attributes for resources datasource * added feature branch * fix test * remove feature branch * enable tests * remove feature branch * refactore * updated docs * update resources datasource: allow to list all resources * fix docs * added optional filters for connectors * enable tests * fix test * revert ci.yml * fix docs * fix linter --------- Co-authored-by: bertekintw <[email protected]>
bertekintw
pushed a commit
that referenced
this pull request
Feb 20, 2024
…urce (#456) * added new attributes for resources datasource * added optional name attributes for resources datasource * added feature branch * fix test * remove feature branch * enable tests * remove feature branch * refactore * added optional filters to users datasource * updated docs * wip: adding acc tests * update resources datasource: allow to list all resources * added tests for email filter * wip: adding user tests * added acctests for users datasource * enable tests * fix test * fix test * fix test * revert ci changes * fix docs * fix linter issue
bertekintw
added a commit
that referenced
this pull request
Feb 20, 2024
…ource (#462) * added new attributes for resources datasource * added optional name attributes for resources datasource * added feature branch * fix test * remove feature branch * enable tests * remove feature branch * refactore * updated docs * update resources datasource: allow to list all resources * fix docs * wip * added group tests * enable test * fix query test * revert ci.yml * fix docs --------- Co-authored-by: bertekintw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #434 #356
Tests passes: https://github.com/vmanilo/terraform-provider-twingate/actions/runs/7306475547
Changes