Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch menu-button to FA icon #68

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

saxamaphone69
Copy link

Switches the 🞃 used for menu-button to its Font Awesome icon equivalent, caret-down, as 🞃 does not render on macOS/iOS. I should note that 4chan X used chevron-down/angle-down - so up to you if you want to switch to that.

This would count as a continuation of #38, and also fixes some of the poor alignment with CSS.
For reference, here's what it looks like:
image

Not sure if switching all the other icons (e.g. close unicode icons, CSS icons in the gallery and menu icon in the header) to the FA icons is something you'd be interested in @TuxedoTako, as per my original PR on 4chan X.

Copy link
Owner

@TuxedoTako TuxedoTako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is preventing you from creating a local test build?

  • Just get node if you don't have that yet, it includes npm.
  • Then open a terminal in your 4chan XT directory.
  • Run npm install to get the dependencies.
  • Run npm run build.

src/Menu/Menu.js Outdated Show resolved Hide resolved
@saxamaphone69
Copy link
Author

I get the npm build stuff and did the little play button like you mentioned last time. I use vscode on my MacBook because I could work it out on Windows. It’s the git stuff I have no clue about.

@saxamaphone69
Copy link
Author

See like I’m sure there is a way to squash or have redo that commit, but no clue.
I don’t know how to make a fork of your fork, make a branch of that fork, pull any changes you’ve made so I have the latest, and then create a pull request.
I know what I need to do, just don’t know how to actually do it.

@saxamaphone69 saxamaphone69 requested a review from TuxedoTako May 31, 2024 22:05
@TuxedoTako
Copy link
Owner

The reason I asked about your build is because you mentioned having trouble with building: #60 (comment), and your change resulting in error messages when just opening a thread, leading me to believe you didn't test locally.

See like I’m sure there is a way to squash or have redo that commit, but no clue.

I think the thing you're looking for is an "interactive rebase", but doing that on a branch you already pushed to github involves git push --force. Anyway, since you want the commits squashed, I'll just do a squash and merge on github.

I don’t know how to make a fork of your fork, make a branch of that fork, pull any changes you’ve made so I have the latest, and then create a pull request.

What do you mean? All your pull requests are correctly created from the latest project-XT branch?

@TuxedoTako TuxedoTako merged commit 9548ca0 into TuxedoTako:project-XT Jun 1, 2024
@saxamaphone69
Copy link
Author

I'm stumbling in the dark and got lucky with where I stepped, I guess.

Thanks for merging. If I find something else, I'll try my best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants