Update Julia compatibility to the new LTS version #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 217 217
=========================================
Hits 217 217 ☔ View full report in Codecov by Sentry. |
|
Is the Test workflow up-to-date? It should show "lts" and "1" as Julia versions. |
Great! done 😃 and please double-check on Bestie, because I think the default there is "1" instead of "lts" 😉 |
abelsiqueira
approved these changes
Oct 10, 2024
.github/workflows/TestOnPRs.yml
Outdated
| @@ -21,7 +21,7 @@ jobs: | |||
| uses: ./.github/workflows/ReusableTest.yml | |||
| with: | |||
| os: ubuntu-latest | |||
| version: "1" | |||
| version: "lts" | |||
There was a problem hiding this comment.
Suggested change
| version: "lts" | |
| version: "1" |
This should be "1", because we test only the latest on PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
There is no related issue.
Checklist