src: precompute field names #1772
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
select benchmark before and after (ran each 30 times before and 30 times after):
|
Field names do not change from row to row, so let's create JS strings only during the process of calling back into JS with the first row, not with each row. We save the JS strings we created while calling back with the first row, and re-use them when creating objects for subsequent rows. Re: nodejs/abi-stable-node#458
gabrielschulhof
force-pushed
the
precompute-field-names
branch
from
0115fa1 to
ff709c4
Compare
|
I don't get why the build fails. node-addon-api requires 16 or 18 or >= 20, and it's getting 18. The version of node should be satisfactory. |
|
@daniellockyer can you please help me figure out why the tests are failing? |
|
Why does tools/semver-check.js claim that the highest supported Node.js version is 10.12.0? That's why all the tests are failing. Can I change it to the current version of Node.js? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field names do not change from row to row, so let's create JS strings only during the process of calling back into JS with the first row, not with each row. We save the JS strings we created while calling back with the first row, and re-use them when creating objects for subsequent rows.
Re: nodejs/abi-stable-node#458