Fixed comments APIs incorrectly returning hidden/deleted replies #21743
+840
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref https://linear.app/ghost/issue/PLG-270/ - added details API tests for members-comments and admin-comments API endpoints - expectations for public comments endpoints: - hidden/deleted comments are never returned unless they have published replies - hidden/deleted replies are never returned - expectations for admin comments endpoints: - deleted comments are never returned unless they have published replies - deleted replies are never returned - hidden comments+replies are always returned (necessary to allow hidden comments to be toggled back to visible)
…lies ref https://linear.app/ghost/issue/PLG-270/ - bookshelf's `.load()` method allows us to pass in an object containing a query builder callback for each relationship. By using that inside of `Comment.findPage()` we're able to apply a `WHERE` query to the replies relationship fetches, allowing us to adjust the filtering depending on whether the query is coming from a public vs an admin endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/ghost/issue/PLG-270/
If the API is returning replies that are not shown in the UI then the comments-ui app isn't able to paginate correctly. This should be true across all comments endpoints with no inconsistency across browse by page or comment, or when fetching individual comments.