-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend api cleaned #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just some suggestions about the comments. Unfortunately it's hard to tell line lengths in this GitHub suggestions interface so these comments might be less than 80 characters wide.
Overall I would try to be more consistently user-centered in writing doc comments, more explicit about all and only the things that the users of these functions should know about. I'd also try to be more precise with language/terminology -- for example, "the fetch call" was mentioned a lot, but to me that refers to the invocation of the fetch()
JavaScript function, not the actual HTTP request being sent over the network.
…boarding into frontend-api-cleaned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes
What changes did you make? Include screenshots if applicable, or explain how to view the changes.
Testing
How did you confirm your changes work? (Automated tests, manual verification, etc.)
Tracking
Add your issue number below.
Resolves #10