Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General principles main view #24

Merged
merged 14 commits into from
Mar 14, 2024
Merged

General principles main view #24

merged 14 commits into from
Mar 14, 2024

Commits on Feb 29, 2024

  1. Added Pressable Component

    @eshaan-s18
    eshaan-s18 committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    61a8fc2 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Merge branch 'main' of https://github.com/TritonSE/DFM-Sideline-Sidek… 

    …ick-App into GeneralPrinciplesMainView
    @r800360
    r800360 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    6aff5c8 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Made series of changes to incorporate dynamic passing of titles to Gl… 

    …obalSearch SearchBarComponent and rewrote styles for Global Search and General Principles to base off of device dimensions, implemented grid structure using Pressables with precise Figma measurements
    @r800360
    r800360 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    8465fcd View commit details
    Browse the repository at this point in the history

  2. Fix some frontend linter issues

    @r800360
    r800360 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    8f2843a View commit details
    Browse the repository at this point in the history

  3. Linter test based on code currently in main

    @r800360
    r800360 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    72453b6 View commit details
    Browse the repository at this point in the history

  4. Putting things back to normal

    @r800360
    r800360 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    164e60a View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Merge branch 'main' into GeneralPrinciplesMainView

    @Anthonyp0329
    Anthonyp0329 committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    99d9484 View commit details
    Browse the repository at this point in the history

  2. searching changes

    @Anthonyp0329
    Anthonyp0329 committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    53e4056 View commit details
    Browse the repository at this point in the history

  3. Fixed text alignment issues w iOS and android

    @eshaan-s18
    eshaan-s18 committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    5d44de6 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Hardcodes font sizes and fixes font weight issues as discussed by Meg… 

    …an and designers
    @r800360
    r800360 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    1b2723d View commit details
    Browse the repository at this point in the history

  2. Changed top padding from 5 percent to 7 percent on Search Page Styles… 

    … container as per Figma measurements
    @r800360
    r800360 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    56585fc View commit details
    Browse the repository at this point in the history

  3. Reverts 7 percent back to 5 percent based on feedback

    @r800360
    r800360 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    be37b87 View commit details
    Browse the repository at this point in the history

  4. Updated to 6% which may have fixed padding top. Commented out marginH… 

    …orizontal to fix search result alignment
    @r800360
    r800360 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    de46962 View commit details
    Browse the repository at this point in the history

  5. Uses the around 7 percent measurement reinforced by Figma while chang… 

    …ing SafeAreaView to regular View in general principles main view to keep consistency between Android and iOS
    @r800360
    r800360 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    56fb1f7 View commit details
    Browse the repository at this point in the history