Feature/pratyush1718/navbar #14
Conversation
…ick-App into feature/pratyush1718/navbar
Anthonyp0329
requested review from
a team,
r800360 and
EdwardLinS
and removed request for
a team
| items.find((item) => item.id === itemId)?.onClick(); | ||
| }; | ||
|
|
||
| const styles = StyleSheet.create({ |
There was a problem hiding this comment.
Put styles into a separate file from the component itself
There was a problem hiding this comment.
Our home page is actually just going to be the global search page, so just make the home page be the search page and feel free to delete this page
| import { StyleSheet, View } from 'react-native'; | ||
| import { Svg, Circle, G } from 'react-native-svg'; | ||
|
|
||
| const styles = StyleSheet.create({ |
There was a problem hiding this comment.
Not sure if it's necessary as it's such a small style sheet, but for consistency's sake, it might be good to move this to its own file as well.
There was a problem hiding this comment.
I apologize for the delay in reviewing this. Nice work with these changes; I tried it out on my Android device and got good results, but on my iPad, I saw that the search icon was not aligned properly. A photo is attached below.
I went ahead and fixed some of the annoying linter issues, and I'll see if I can take care of the package.json/package-lock.json issues; hopefully more do not pop up. I think the pending issues to focus on as discussed previously are:
- Making separate files for the styles in the Stylesheets
- Change home page to global search page
- iPad issue described here
Otherwise, very well done!
…flicts in package.json and package-lock.json
|
Alright linter issues and package.json/package-lock.json merge conflict are all taken care of, so this concludes my commits to the branch as of now. |
Tracking Info
Resolves #3
Changes
Add a bottom nav bar component per figma designs. Also added stack navigation for different button clicks on the nav bar.
Testing
Tested using android emulator, ss below