Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET 9 #899

Merged
merged 1 commit into from
Dec 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/gh-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
pull_request:

env:
DOTNET_VERSION: '8.0.x'
DOTNET_VERSION: '9.0.x'

jobs:
build:
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
FROM mcr.microsoft.com/dotnet/sdk:8.0 AS build
FROM mcr.microsoft.com/dotnet/sdk:9.0 AS build
WORKDIR /src
COPY . .
RUN dotnet build -c Release

FROM mcr.microsoft.com/dotnet/runtime:8.0
FROM mcr.microsoft.com/dotnet/runtime:9.0
WORKDIR /app
COPY --from=build /src/WowPacketParser/bin/Release .
COPY --chmod=755 ./docker-entrypoint.sh /
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ WowPacketParser (WPP)
Usage
-----

* Compile WowPacketParser using Visual Studio 2022 (with .NET 8.0 SDK) or .NET 8.0 SDK (Linux/macOS).
* Compile WowPacketParser using Visual Studio 2022 (with .NET 9.0 SDK) or .NET 9.0 SDK.
Alternatively you can download compiled binaries from the links [below](#nightly-builds).
* Edit `WowPacketParser.dll.config` to fit your needs.
* Drag one or more files (.pkt or .bin) to `WowPacketParser.exe`.
Expand Down Expand Up @@ -39,9 +39,9 @@ and `wpp_data_objectnames.sql` has some data to fill the database.

Nightly Builds
--------------
.NET 8.0 SDK or .NET 8.0 Runtime is needed!
.NET 9.0 SDK or .NET 9.0 Runtime is needed!

[Download .NET 8.0 here!](https://dotnet.microsoft.com/download/dotnet/8.0)
[Download .NET 9.0 here!](https://dotnet.microsoft.com/download/dotnet/9.0)

##### Windows
- Visual Studio 2022
Expand Down
4 changes: 2 additions & 2 deletions WowPacketParser.Proto/WowPacketParser.Proto.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Google.Protobuf" Version="3.26.0" />
<PackageReference Include="Google.Protobuf" Version="3.29.0" />
<PackageReference Include="Grpc" Version="2.46.6" />
<PackageReference Include="Grpc.Tools" Version="2.62.0">
<PackageReference Include="Grpc.Tools" Version="2.68.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
6 changes: 3 additions & 3 deletions WowPacketParser.Tests/WowPacketParser.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="nunit" Version="4.1.0" />
<PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
<PackageReference Include="nunit" Version="4.2.2" />
<PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
</ItemGroup>

<ItemGroup>
Expand Down
11 changes: 7 additions & 4 deletions WowPacketParser/WowPacketParser.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,15 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="MySql.Data" Version="8.3.0" />
<PackageReference Include="MySql.Data" Version="9.1.0" />
<PackageReference Include="RawScape.Wintellect.PowerCollections" Version="1.0.1" />
<PackageReference Include="Sigil" Version="5.0.0" />
<PackageReference Include="SSH.NET" Version="2024.0.0" />
<PackageReference Include="System.Configuration.ConfigurationManager" Version="8.0.0" />
<PackageReference Include="System.Data.SQLite.Core" Version="1.0.118" />
<PackageReference Include="SSH.NET" Version="2024.2.0" />
<PackageReference Include="System.Configuration.ConfigurationManager" Version="9.0.0" />
<PackageReference Include="System.Data.SQLite.Core" Version="1.0.119" />

<!-- Fix for transitive packets triggering https://github.com/advisories/GHSA-8g4q-xg66-9fp4 -->
<PackageReference Include="System.Text.Json" Version="9.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion default.props
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>
<PropertyGroup>
<OutputPath>bin/$(Configuration)/</OutputPath>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<LangVersion>latest</LangVersion>
<Company>TrinityCore</Company>
<Copyright>Copyright © 2010-2024</Copyright>
Expand Down
Loading