Add all sod versions that are missing #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killerwife
force-pushed
the
feature/SodVersions
branch
3 times, most recently
from
3f871a2 to
5dc2c5c
Compare
killerwife
force-pushed
the
feature/SodVersions
branch
from
f0ad36c to
006d96d
Compare
killerwife
commented
Nov 3, 2024
| @@ -40,7 +40,7 @@ public static void HandleServerChatMessage(Packet packet) | |||
| packet.ReadInt32("AchievementID"); | |||
|
|
|||
| uint chatFlags = 0; | |||
| if (ClientVersion.AddedInVersion(ClientVersionBuild.V4_4_1_57294)) | |||
There was a problem hiding this comment.
@Ovahlord this is the change i talked about. Scan through this pr pls if it makes your life in any way harder, if it does, ill have to duplicate some things massively but it is doable.
killerwife
force-pushed
the
feature/SodVersions
branch
from
76a83cf to
5e63dfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.