refactor: simplify getProviderType code

TrilonIO · Feb 21, 2024 · 51a7e69 · 51a7e69
1 parent 93553a2
commit 51a7e69
Showing 1 changed file with 12 additions and 34 deletions.
diff --git a/src/rules/enforce-custom-provider-type.rule.ts b/src/rules/enforce-custom-provider-type.rule.ts
@@ -146,40 +146,18 @@ function getProviderType(node: TSESTree.Identifier): ProviderType | undefined {
     if (init?.type === AST_NODE_TYPES.ObjectExpression) {
       const properties = init.properties;
       for (const property of properties) {
-        if (
-          property.type === AST_NODE_TYPES.Property &&
-          ASTUtils.isIdentifier(property.key) &&
-          property.key.name === 'useFactory'
-        ) {
-          type = 'factory';
-          break;
-        }
-
-        if (
-          property.type === AST_NODE_TYPES.Property &&
-          ASTUtils.isIdentifier(property.key) &&
-          property.key.name === 'useClass'
-        ) {
-          type = 'class';
-          break;
-        }
-
-        if (
-          property.type === AST_NODE_TYPES.Property &&
-          ASTUtils.isIdentifier(property.key) &&
-          property.key.name === 'useValue'
-        ) {
-          type = 'value';
-          break;
-        }
-
-        if (
-          property.type === AST_NODE_TYPES.Property &&
-          ASTUtils.isIdentifier(property.key) &&
-          property.key.name === 'useExisting'
-        ) {
-          type = 'existing';
-          break;
+        if (property.type === AST_NODE_TYPES.Property) {
+          const propertyKey = (property.key as TSESTree.Identifier)?.name;
+          type =
+            propertyKey === 'useClass'
+              ? 'class'
+              : propertyKey === 'useFactory'
+                ? 'factory'
+                : propertyKey === 'useValue'
+                  ? 'value'
+                  : propertyKey === 'useExisting'
+                    ? 'existing'
+                    : undefined;
         }
       }
     }