Some refactorings I noticed while working on #299 #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riBITSPub#411) I just noticed that CMake 3.17 suppports string(APPEND ...). The more that we can remove from TriBITS the better.
I manaully tested this for all of the various use cases. It is always a good idea to break the tests from time-to-time and make sure the test support code catches and reports the errors correctly.
|
It would be nice if this was reviewed but there is no one to do it so I will just merge this. (Someone can review this PR most-merge if they like.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just refactorings to get ready for more work on #299. I am also addressing a few things for EPIC #411.
See the individual commits.