I1308 docker base image for release #1320
Conversation
| RUN echo "deb http://cran.rstudio.com/bin/linux/debian lenny-cran/" >> /etc/apt/source.list &&\ | ||
| apt-key adv --keyserver hkp://pgp.mit.edu --recv-key 381BA480 &&\ | ||
| apt-get update &&\ | ||
| apt-get install -y r-base &&\ | ||
| apt-get install -y unzip &&\ | ||
| apt-get install -y r-base &&\ |
There was a problem hiding this comment.
I thought we are removing this. Or is that a separate issue?
There was a problem hiding this comment.
#1316 for removing R
docker/smv/Dockerfile
Outdated
|
|
||
| COPY --from=smv-build ${PYENV_ROOT} ${PYENV_ROOT} | ||
| COPY --from=smv-build /usr/lib/SMV/smv_*.tgz . | ||
| RUN tar xzvf smv_*.tgz && rm -rf smv_*.tgz && mv ./SMV ${SMV_HOME} &&\ |
There was a problem hiding this comment.
This block really needs a comment to explain what is going on and why.
There was a problem hiding this comment.
Added a header comment to describe the multi-stage pattern and some inline comments explaining the copies from first to second stage.
| py-doc: $(PYDOC_DEST) | ||
|
|
||
| $(PYDOC_DEST): install-spark-default | ||
| env SMV_VERSION=$(SMV_VERSION) \ |
There was a problem hiding this comment.
I doubt using env is the best solution to the problem of exporting env variables to sphinx. It was the first I got to work. Need to at least dry out this approach since it is c/p'd a few lines down.
There was a problem hiding this comment.
actually env is the "unixish" way. That is the whole purpose of env existence 😄
docker/smv/Dockerfile
Outdated
| COPY --from=smv-build ${PYENV_ROOT} ${PYENV_ROOT} | ||
| # Copy the SMV release artifact from the first stage and unpack it. Since the same artifact is also copied |
| py-doc: $(PYDOC_DEST) | ||
|
|
||
| $(PYDOC_DEST): install-spark-default | ||
| env SMV_VERSION=$(SMV_VERSION) \ |
There was a problem hiding this comment.
actually env is the "unixish" way. That is the whole purpose of env existence 😄
Resolves #1308.
@jacobdr Please have a look tomorrow if you have time.
The goal of this PR is to reduce the complexity of
smv-release.