-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back SMV base Docker image for building release #1308
Comments
This should fix #1307 since the requirements installed will no longer be the requirements of the previous release. Once we confirm we can close that ticket. |
We will use a multi-stage build to accomplish the base image / publishable image approach. The base image will build the release artifact, and the publishable image will unpack it. This will help ensure that
this will also simplify the surrounding tooling. |
Sounds good 👍 |
Currently we have a bit of a convoluted approach to using Docker to standardize the environment for the release build. The short of it is that we build a docker image based on the old release to use when building the new release. This leads to complications. Instead we should create a base image with all of SMV's dependencies to use when building the new release artifact. The SMV image which we publish will be based on this image and will install SMV by unpacking the release artifact which we've just published.
The text was updated successfully, but these errors were encountered: