Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back SMV base Docker image for building release #1308

Closed
laneb opened this issue Jul 10, 2018 · 3 comments
Closed

Bring back SMV base Docker image for building release #1308

laneb opened this issue Jul 10, 2018 · 3 comments
Assignees
Labels

Comments

@laneb
Copy link
Contributor

laneb commented Jul 10, 2018

Currently we have a bit of a convoluted approach to using Docker to standardize the environment for the release build. The short of it is that we build a docker image based on the old release to use when building the new release. This leads to complications. Instead we should create a base image with all of SMV's dependencies to use when building the new release artifact. The SMV image which we publish will be based on this image and will install SMV by unpacking the release artifact which we've just published.

@laneb laneb added the internal label Jul 10, 2018
@laneb
Copy link
Contributor Author

laneb commented Jul 10, 2018

This should fix #1307 since the requirements installed will no longer be the requirements of the previous release. Once we confirm we can close that ticket.

@laneb
Copy link
Contributor Author

laneb commented Jul 23, 2018

We will use a multi-stage build to accomplish the base image / publishable image approach. The base image will build the release artifact, and the publishable image will unpack it. This will help ensure that

  1. the published image is as skinny as possible
  2. the contents of the published image are the same as the published artifact (this has been a recurring problem)

this will also simplify the surrounding tooling.

@laneb laneb mentioned this issue Jul 23, 2018
@AliTajeldin
Copy link
Contributor

Sounds good 👍

laneb added a commit that referenced this issue Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants