Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release process broken when new requirement added #1307

Open
laneb opened this issue Jul 9, 2018 · 1 comment
Open

Release process broken when new requirement added #1307

laneb opened this issue Jul 9, 2018 · 1 comment

Comments

@laneb
Copy link
Contributor

laneb commented Jul 9, 2018

The release validation is run in a docker container based on the Dockerfile from the top of the release brannch. The Dockerfile currently installs the most recent SMV release for that release train, and the requirements are taken from that release. That means that the requirements that are installed in the image used for validation of the new release are the requirements of the old release. When new requirements are added - tox, for recent example - they're not installed in the image used for validation, and fail the tests if they're truly requirements.

@laneb
Copy link
Contributor Author

laneb commented Aug 3, 2018

Should be fixed now, but need to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants